Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Fix for checkForFunctionProperty so that order does not matter #6384

Merged
merged 1 commit into from
Apr 12, 2024
Merged

[Backport 2.x] Fix for checkForFunctionProperty so that order does not matter #6384

merged 1 commit into from
Apr 12, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport b70c327 from #6248.

@github-actions
Fix for checkForFunctionProperty so that order does not matter (#6248)
e577fcd 
* Fix for checkForFunctionProperty so that order does not matter

Signed-off-by: Craig Perkins <[email protected]>

* Remove import for inspect

Signed-off-by: Craig Perkins <[email protected]>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

* replace with jest.fn()

Signed-off-by: Craig Perkins <[email protected]>

* Update CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

* Add scenarios where object does not contain fn

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: SuZhou-Joe <[email protected]>
Co-authored-by: ZilongX <[email protected]>
(cherry picked from commit b70c327)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot added bug Something isn't working autocut Skip the changelog verification check on backports repeat-contributor v2.14.0 labels Apr 9, 2024
@ananzh ananzh merged commit c3c0b08 into 2.x Apr 12, 2024
88 of 89 checks passed
@github-actions github-actions bot deleted the backport/backport-6248-to-2.x branch April 12, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh ananzh approved these changes

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports bug Something isn't working repeat-contributor v2.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SuZhou-Joe @ananzh